Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40612 )
Change subject: soc/intel/jasperlake: Enable end of post support in FSP ......................................................................
Patch Set 10:
(7 comments)
https://review.coreboot.org/c/coreboot/+/40612/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40612/5//COMMIT_MSG@11 PS5, Line 11: applicable
Yes Furquan. Updated the commit message.
Done
https://review.coreboot.org/c/coreboot/+/40612/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40612/9//COMMIT_MSG@10 PS9, Line 10: DXE modules are not part of FSP
nit: in API mode which coreboot currently uses.
Done
https://review.coreboot.org/c/coreboot/+/40612/1/src/soc/intel/jasperlake/fs... File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/40612/1/src/soc/intel/jasperlake/fs... PS1, Line 101: EndOfPostMessage
Added, please review.
Done
https://review.coreboot.org/c/coreboot/+/40612/1/src/soc/intel/jasperlake/fs... PS1, Line 101: 0x01
Yes, this is issue EOP in PEI phase. The DXE EOP implementation does not apply for coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/40612/4/src/soc/intel/jasperlake/fs... File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/40612/4/src/soc/intel/jasperlake/fs... PS4, Line 103: Send
Sure, Updated as enum. […]
Ack
https://review.coreboot.org/c/coreboot/+/40612/9/src/soc/intel/jasperlake/fs... File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/40612/9/src/soc/intel/jasperlake/fs... PS9, Line 20: )
nit: in API mode
Done
https://review.coreboot.org/c/coreboot/+/40612/9/src/soc/intel/jasperlake/fs... PS9, Line 21: )
nit: in API mode
Done