[coreboot-gerrit] Change in coreboot[master]: nb/amd/common: Move RAM calcualtion to common code

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Nico Huber, Michał Żygowski, Michał Kopeć, Paul Menzel, Angel Pons, Arthur Heymans, Krystian Hebel.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61682 )

Change subject: nb/amd/common: Move RAM calcualtion to common code
......................................................................

Patch Set 6:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/61682/comment/32b6fa84_b273c47b 
PS6, Line 7: nb/amd/common: Move RAM calcualtion to common code
calculation

File src/northbridge/amd/agesa/family14/northbridge.c:

https://review.coreboot.org/c/coreboot/+/61682/comment/908ec2f2_6726f3f9 
PS6, Line 27: static unsigned int fx_devs = 0;
> I'd simplify the fx_devs stuff first.

There is no perfect order. Addressing fx_devs arrays soon extends to no longer passing nodeid and at the end of the day, majority of the code review ends up with code removals like in CB:52934.

https://review.coreboot.org/c/coreboot/+/61682/comment/80a06a93_aa220430 
PS6, Line 27: static unsigned int fx_devs = 0;
> I'd simplify the fx_devs stuff first.

Ack

https://review.coreboot.org/c/coreboot/+/61682/comment/8fd08925_ace9250e 
PS6, Line 100: 		dev = __f1_dev[i];
> dev = pcidev_on_root(DEV_CDB, 1) ?

Ack

File src/northbridge/amd/common/ram_calc.c:

https://review.coreboot.org/c/coreboot/+/61682/comment/2855a570_41d3878d 
PS5, Line 28: >
> No, this is correct, and comment in line #25 is wrong. […]

Ack