Attention is currently required from: Arthur Heymans, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Morgan Jang, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54093 )
Change subject: security/intel/cbnt: Add logging
......................................................................
Patch Set 10: Code-Review+1
(2 comments)
File src/security/intel/cbnt/logging.c:
https://review.coreboot.org/c/coreboot/+/54093/comment/de70534e_92ceb6a4
PS10, Line 121: printk(BIOS_DEBUG, "CBNT:\tSACM INFO MSR (0x13A) raw: 0x%016llx\n", acm_info.raw);
printk(BIOS_DEBUG, "CBNT: could be replaced with a macro
Maybe borrow the CBFS macros, amd adapt them as needed?
#define ERROR(...) printk(BIOS_ERR, "CBnT ERROR: " __VA_ARGS__)
#define LOG(...) printk(BIOS_INFO, "CBnT: " __VA_ARGS__)
#define DEBUG(...) do { \
if (CONFIG(DEBUG_CBFS)) \
printk(BIOS_SPEW, "CBnT DEBUG: " __VA_ARGS__); \
} while (0)
https://review.coreboot.org/c/coreboot/+/54093/comment/37be020a_8911142d
PS10, Line 122: \
for proper tables please use fixed width using %-20s notation instead of \t
I generally use spaces to indent these
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54093
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b57132bedbd944b9861ab0e2e0d14723cb61635
Gerrit-Change-Number: 54093
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 15 Jun 2021 08:42:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment