Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44302 )
Change subject: mb/lenovo/thinkcentre_m91p add ThinkCentre M91p ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44302/1/src/mainboard/lenovo/thinkc... File src/mainboard/lenovo/thinkcentre_m91p/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/44302/1/src/mainboard/lenovo/thinkc... PS1, Line 60: device pci 1c.0 off # PCIe Port #1 : end : device pci 1c.1 off # PCIe Port #2 : end : device pci 1c.2 off # PCIe Port #3 : end : device pci 1c.3 off # PCIe Port #4 : end : device pci 1c.4 off # PCIe Port #5 : end : device pci 1c.5 off # PCIe Port #6 : end : device pci 1c.6 off # PCIe Port #7 : end : device pci 1c.7 off # PCIe Port #8 : end
Done
No, what I meant is that the mainboard has PCIe slots, so that they are disabled is weird. I'll comment on the latest patchset according to schematics
https://review.coreboot.org/c/coreboot/+/44302/5/src/mainboard/lenovo/thinkc... File src/mainboard/lenovo/thinkcentre_m91p/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/44302/5/src/mainboard/lenovo/thinkc... PS5, Line 16: device domain 0x0 on Since the subsystem ID is the same everywhere, you can remove all `subsystemid` lines and put this here:
subsystemid 0x17aa 0x3070 inherit
Saves some redundancy 😄
https://review.coreboot.org/c/coreboot/+/44302/5/src/mainboard/lenovo/thinkc... PS5, Line 20: end This is part of the comment (comments begin with `#` in the devicetree), so it most likely doesn't build. It should be:
device pci 01.0 off end # PEG
And actually, it should be on: this is the PCIe x16 slot.
https://review.coreboot.org/c/coreboot/+/44302/5/src/mainboard/lenovo/thinkc... PS5, Line 45: device pci 1c.0 off # PCIe Port #1 end We need to keep unused root ports here, otherwise they will be enabled. According to schematics:
device pci 1c.0 off end # PCIe Port #1 device pci 1c.1 off end # PCIe Port #2 device pci 1c.2 off end # PCIe Port #3 device pci 1c.3 off end # PCIe Port #4 device pci 1c.4 on end # PCIe Port #5 - PCIe x1 slot device pci 1c.5 off end # PCIe Port #6 device pci 1c.6 off end # PCIe Port #7 device pci 1c.7 off end # PCIe Port #8