Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48143 )
Change subject: mb/kontron/mal10: Use mainboard_ops driver for GPIO configuration
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48143/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48143/6//COMMIT_MSG@11
PS6, Line 11: the init phase from the mainboard_ops driver for configuring the GPIOs.
Have you tested whether the final GPIO settings remain unaffected with this patch? If GPIOs are now configured after FSP-S has run, there could be differences.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48143
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia01091938ac113cb5cf95f046609a1ebf3620806
Gerrit-Change-Number: 48143
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 04 Jan 2021 18:35:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment