25 Nov
2020
25 Nov
'20
5:41 p.m.
Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47990 )
Change subject: soc/intel/common/fast_spi: Add extended decode window support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47990/2/src/soc/intel/common/block/... File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/47990/2/src/soc/intel/common/block/... PS2, Line 277: SPI_DMI_DESTINATION_ID
Looks like the compiler is complaining about this being not defined for any boards other than the TG […]
sure, sounds good. Let me give it a try
--
To view, visit https://review.coreboot.org/c/coreboot/+/47990
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idafd8be0261892122d0b5a95d9ce9d5604a10cf2
Gerrit-Change-Number: 47990
Gerrit-PatchSet: 2
Gerrit-Owner: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Nov 2020 01:41:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment