Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47086 )
Change subject: libpayload/keyboard: Turn init sequence into a state machine
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47086/1/payloads/libpayload/drivers...
File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/47086/1/payloads/libpayload/drivers...
PS1, Line 455: void keyboard_disconnect(void)
Yep, thanks! I'm not used to returning to the payload, but console_init() […]
Done (still have to teach payloads to call this function, though).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47086
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9cf5cf31eb420b3994bec20e56a72d37f3d2996e
Gerrit-Change-Number: 47086
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Matt Delco
delco@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 14 Nov 2020 14:38:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment