Attention is currently required from: Paul Menzel, Furquan Shaikh, Tim Wawrzynczak, Brandon Breitenstein.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56839 )
Change subject: mb/adlrvp: Add new ADL P board variant for MCHP1727
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/intel/adlrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/56839/comment/42bb31f8_d393674a
PS7, Line 41: adlrvp_p_ext_ec
Actually if I am reading this code correctly, is the correct overridetree.cb being selected?
The OVERRIDE_DEVICETREE is defined as
`variants/$(CONFIG_VARIANT_DIR)/overridetree.cb`
and right here VARIANT_DIR is set as adlrvp_p_ext_ec, so shouldn't the overridetree.cb used be:
`variants/adlrvp_p_ext_ec/overridetree.cb`
while below it's
`variants/adlrvp_p_mchp/overridetree.cb`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56839
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dc96ad5c5db21fedbe480d19fcae8434d3bd169
Gerrit-Change-Number: 56839
Gerrit-PatchSet: 7
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Vijay P Hiremath
vijay.p.hiremath@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Comment-Date: Wed, 01 Sep 2021 22:16:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment