11 Feb
2020
11 Feb
'20
5:36 a.m.
Roja Rani Yarubandi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37306 )
Change subject: trogdor: mainboard reference all QUPv3 FW drivers ......................................................................
Patch Set 18:
(1 comment)
Patch Set 18:
(1 comment)
Done, shared patch with Mike
https://review.coreboot.org/c/coreboot/+/37306/18/src/mainboard/google/trogd... File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/37306/18/src/mainboard/google/trogd... PS18, Line 47: i2c_init(QUPV3_1_SE3, I2C_SPEED_FAST); /* Speaker Amps I2C */
I think this is missing 0_SE5 (SAR) and 1_SE5 (codec) from the old config, where did they go? (I thi […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/37306
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ff5dd63fac28ffa558aec71e79a6de87d7885e0
Gerrit-Change-Number: 37306
Gerrit-PatchSet: 18
Gerrit-Owner: mturney mturney mturney@codeaurora.org
Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Akash Asthana akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Roja Rani Yarubandi c_rojay@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Tue, 11 Feb 2020 13:36:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment