Attention is currently required from: Jérémy Compostella.
Jincheng Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81260?usp=email )
Change subject: arch/x86: Fix typo for marco CPUID_FEATURE_HTT ......................................................................
arch/x86: Fix typo for marco CPUID_FEATURE_HTT
Also use BIT marco to replace the original manual bit shift
Change-Id: I9b29233e75483cda6bf7723cf79632f6b04233b0 Signed-off-by: Jincheng Li jincheng.li@intel.com --- M src/arch/x86/include/arch/cpu.h M src/cpu/intel/common/hyperthreading.c 2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/81260/1
diff --git a/src/arch/x86/include/arch/cpu.h b/src/arch/x86/include/arch/cpu.h index 0c4decf..2236781 100644 --- a/src/arch/x86/include/arch/cpu.h +++ b/src/arch/x86/include/arch/cpu.h @@ -47,9 +47,9 @@ #define X86_VENDOR_ANY 0xfe #define X86_VENDOR_UNKNOWN 0xff
-#define CPUID_FEATURE_PAE (1 << 6) -#define CPUID_FEATURE_PSE36 (1 << 17) -#define CPUID_FEAURE_HTT (1 << 28) +#define CPUID_FEATURE_PAE BIT6 +#define CPUID_FEATURE_PSE36 BIT17 +#define CPUID_FEATURE_HTT BIT28
/* Structured Extended Feature Flags */ #define CPUID_STRUCT_EXTENDED_FEATURE_FLAGS 0x7 diff --git a/src/cpu/intel/common/hyperthreading.c b/src/cpu/intel/common/hyperthreading.c index 85c4477..d034129 100644 --- a/src/cpu/intel/common/hyperthreading.c +++ b/src/cpu/intel/common/hyperthreading.c @@ -7,7 +7,7 @@ bool intel_ht_supported(void) { /* Is HyperThreading supported? */ - return !!(cpuid_edx(1) & CPUID_FEAURE_HTT); + return !!(cpuid_edx(1) & CPUID_FEATURE_HTT); }
/*