Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32549 )
Change subject: soc/intel/common: Hook up GMA ACPI brightness controls
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/32549/7/src/soc/intel/common/block/...
File src/soc/intel/common/block/graphics/graphics.c:
https://review.coreboot.org/c/coreboot/+/32549/7/src/soc/intel/common/block/...
PS7, Line 37: *
I think it's common to keep the asterisk on the first line in such a case,
but I'm not sure.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32549
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I993770fdcd0a28cee756df2bd6a795498f175952
Gerrit-Change-Number: 32549
Gerrit-PatchSet: 7
Gerrit-Owner: Matthew Garrett
mjg59@google.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Matthew Garrett
mjg59@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Fri, 27 Mar 2020 20:39:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment