Attention is currently required from: Angel Pons. Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47595 )
Change subject: ec/kontron/kempld: Add minimal GPIO driver ......................................................................
Patch Set 9:
(4 comments)
File src/ec/kontron/kempld/kempld.c:
https://review.coreboot.org/c/coreboot/+/47595/comment/a479367b_1c4b5ad4 PS5, Line 99: GPIOs configuration
nit: either `GPIO configuration` or `Configuring GPIOs`. I prefer the former.
Done
https://review.coreboot.org/c/coreboot/+/47595/comment/7bc19adb_30c7e042 PS5, Line 100: }
else, warn? it would be consistent with the code above: […]
Done
File src/ec/kontron/kempld/kempld_internal.h:
https://review.coreboot.org/c/coreboot/+/47595/comment/e41511db_17a2e973 PS5, Line 33: /
nit: spaces around `/`
Done
https://review.coreboot.org/c/coreboot/+/47595/comment/0c519f74_b9fd933b PS5, Line 33: 8
Given that `KEMPLD_NUM_GPIO_PADS` is 8, the parametrization seems pointless. […]
Done