Attention is currently required from: Shelley Chen.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79855?usp=email )
Change subject: mb/google/brox: Disable package c state demotion ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79855/comment/f1e324b4_ffc00853 : PS2, Line 7: Disable package c state demotion … unsupported on RPL
https://review.coreboot.org/c/coreboot/+/79855/comment/f1752210_9a750f60 : PS2, Line 11: [EMERG] ASSERTION ERROR: file 'src/soc/intel/alderlake/fsp_params.c', : line 1066 Maybe also describe, what that assertion checks, and why it’s there.
https://review.coreboot.org/c/coreboot/+/79855/comment/b4062e09_45e4e037 : PS2, Line 11: [EMERG] ASSERTION ERROR: file 'src/soc/intel/alderlake/fsp_params.c', : line 1066 I’d put it in one line and indent it with four spaces.