Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29977 )
Change subject: sb/intel/common: Create a common PCH finalise implementation
......................................................................
Patch Set 2: Code-Review+1
sorry, wrong button...
I've compared object files for an Ivy Bridge build, looks good apart
from the comments.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29977
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I781082b1ed507b00815d1e85aec3e56ae5a4bef2
Gerrit-Change-Number: 29977
Gerrit-PatchSet: 2
Gerrit-Owner: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 01 Dec 2018 14:50:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment