Hello Angel Pons, Julius Werner, build bot (Jenkins), Nico Huber, Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34296
to look at the new patch set (#2).
Change subject: soc/rockchip/rk3288: Add fall through comment ......................................................................
soc/rockchip/rk3288: Add fall through comment
To break, or not to break, that is the question. -- Hamlet, probably
The case statement for INIT_MEM does not have a break, and so falls through to the one for CONF. Is this intentional, or is it a mistake? Well, it doesn't completely matter, since if a break were added the state would be CONF on the next iteration of the while loop, and so it would execute the CONF case anyway. To be safe however, let's leave the existing control flow and add a comment that the fall through is intentional.
Change-Id: I1d0cfea07211c54d6a906f5a7481c2c760f8ef0d Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: Coverity CID 1291959 --- M src/soc/rockchip/rk3288/sdram.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/34296/2