Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48118 )
Change subject: mb/intel/ehlcrb: Remove ChromeOS EC support EHL smihandler ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG@7 PS1, Line 7: Remove ChromeOS EC support EHL smihandler Remove ChromeOS EC support from smihandler
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG@9 PS1, Line 9: EHL EHL CRB
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG@10 PS1, Line 10: codes support
https://review.coreboot.org/c/coreboot/+/48118/1//COMMIT_MSG@11 PS1, Line 11: In fact you are completely dropping smihandler.c instead of removing parts of it. Why not just say something like "Since there is no ChromeOS support for EHL CRB, drop smihandler.c which just deals with ChromeOS support."?