Sam Lewis has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35409 )
Change subject: arch/arm: Allow program loading of Linux kernels
......................................................................
Patch Set 5:
(Note that it actually says BLX in the disassembly you provided, is that from you fixing it manually?)
Correct, that was from me manually fixing it.
I agree, with all these intricacies, just making it a real assembly function in a separate file is probably better.
Have created a new patch that does this with an assembly function, submitted here: https://review.coreboot.org/c/coreboot/+/45335
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35409
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0dcc26d647941de71669345911ba288341b834b
Gerrit-Change-Number: 35409
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sam Lewis
sam.vr.lewis@gmail.com
Gerrit-Comment-Date: Mon, 14 Sep 2020 11:28:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment