Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48156 )
Change subject: arch/x86: Don't use .bss from car.ld if not running XIP ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48156/1/src/arch/x86/assembly_entry... File src/arch/x86/assembly_entry.S:
https://review.coreboot.org/c/coreboot/+/48156/1/src/arch/x86/assembly_entry... PS1, Line 39: ENV_STAGE_XIP
Using this rule will eliminate clearing .bss on Picasso where we have CONFIG(RESET_VECTOR_IN_RAM). You can objdump romstage for a Mandolin build and check it.
Is it needed? When a program is actually loaded into CAR/dram the program loader should clear out .bss. It's only why when the program XIP, that the program is not loaded that we have to manually make sure .bss is cleared.