Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34386 )
Change subject: util/lint/checkpatch.pl: Update line length to 96
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34386/1/util/lint/checkpatch.pl
File util/lint/checkpatch.pl:
https://review.coreboot.org/c/coreboot/+/34386/1/util/lint/checkpatch.pl@54
PS1, Line 54: my $max_line_length = 96;
Hmmm... maybe I was wrong. It looks like we do still get the warning sometimes (e.g. https://review. […]
That happened because that patchset was based on a commit that didn't have the 96 characters per line override yet: the tests are always executed from the tree that is under test. That generally doesn't matter too much, but we may have to revisit that approach.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34386
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f34c93c2af4a7f1928af28320ef2abd66dac0bb
Gerrit-Change-Number: 34386
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 17 Jul 2019 21:32:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment