Bob Moragues has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37645 )
Change subject: mb/google/hatch: Add mushu variant
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37645/7/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/37645/7/src/mainboard/google/hatch/...
PS7, Line 44: BOARD_ROMSIZE_KB_32768
Is this accurate for Mushu? I know this is a copy of Hatch reference, but most boards based on Hatch […]
The schematic still shows the 32MB part.
They may be changing that. I will start an email thread on this.
https://review.coreboot.org/c/coreboot/+/37645/7/src/mainboard/google/hatch/...
PS7, Line 45: ROMSTAGE_SPD_SMBUS
This is not correct. Mushu would still use CBFS SPD.
I double checked the Hatch reference board. It is still using ROMSTAGE_SPD_SMBUS.
Has CBFS SPD been rolled out to all the hatch variants?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37645
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81b5bf960ead0463159ac35f4f96e3ccc8c0364e
Gerrit-Change-Number: 37645
Gerrit-PatchSet: 7
Gerrit-Owner: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philip Chen
philipchen@chromium.org
Gerrit-Reviewer: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matthew Blecker
matthewb@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 17 Dec 2019 04:43:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment