Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44375 )
Change subject: libpayload: cbgfx: Add color mapping functionality ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44375/3/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/44375/3/payloads/libpayload/drivers... PS3, Line 59: = { : .x = 0, : .y = 0, : };
Since it's the zero vector, I think it's fine to explicitly initialize it?
This is just a matter of taste, there is no hard rule... personally, I think it's perfectly fine to explicitly zero-initialize globals for clarity (it can help make the difference between "the initial value of this global doesn't matter" and "the initial value of this global must be 0 for good reason" a bit clearer).