Attention is currently required from: Michał Żygowski, Michał Kopeć.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 )
Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ......................................................................
Patch Set 3:
(10 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161310): https://review.coreboot.org/c/coreboot/+/68791/comment/bb9a42e4_b8f126ee PS3, Line 48: Signed-off-by: Michał Kopeć michal.kopec@3mdeb.com Non-standard signature: Co-authored-by:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161310): https://review.coreboot.org/c/coreboot/+/68791/comment/276bf898_812c6b1b PS3, Line 49: Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Non-standard signature: Co-authored-by:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161310): https://review.coreboot.org/c/coreboot/+/68791/comment/547d02d0_b4df3d6e PS3, Line 50: Signed-off-by: Michael Niewöhner foss@mniewoehner.de Non-standard signature: Co-authored-by:
File src/ec/clevo/it5570e/commands.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161310): https://review.coreboot.org/c/coreboot/+/68791/comment/c490d983_a139c3f0 PS3, Line 41: while (recv_ec_data() != '$'); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161310): https://review.coreboot.org/c/coreboot/+/68791/comment/6ad4f58a_6a35475a PS3, Line 119: else if (start > 100 || stop > 100) { else should follow close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161310): https://review.coreboot.org/c/coreboot/+/68791/comment/7274ba64_ada02abd PS3, Line 122: else if (start >= stop) { else should follow close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161310): https://review.coreboot.org/c/coreboot/+/68791/comment/6f72cdc6_31938bed PS3, Line 142: * The EC maintains the camera´s state in RAM. However, it doesn't sync the GPIO line length of 97 exceeds 96 columns
File src/ec/clevo/it5570e/ec.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161310): https://review.coreboot.org/c/coreboot/+/68791/comment/ebaee1fb_f5158fd9 PS3, Line 124: if (dev->path.type == DEVICE_PATH_GENERIC && dev->path.generic.id == 0) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161310): https://review.coreboot.org/c/coreboot/+/68791/comment/26e1cf67_03f28c02 PS3, Line 127: else { else should follow close brace '}'
File src/ec/clevo/it5570e/ssdt.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161310): https://review.coreboot.org/c/coreboot/+/68791/comment/afd588ec_276733f7 PS3, Line 140: for (int i = 0; i < fan_cnt; i++) { braces {} are not necessary for single statement blocks