[coreboot-gerrit] Change in coreboot[master]: EC sync: Properly handle VBERROR return codes from vb2api_ec_sync

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37562 )

Change subject: EC sync: Properly handle VBERROR return codes from vb2api_ec_sync
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37562/3/src/security/vboot/ec_sync.... 
File src/security/vboot/ec_sync.c:

https://review.coreboot.org/c/coreboot/+/37562/3/src/security/vboot/ec_sync.... 
PS3, Line 71: EC_REBOOT_FLAG_ON_AP_SHUTDOWN
> Actually, sorry, on second thought this seems to be a problem. […]

You're right, this won't work since we're not powering down the AP now.  It'll be a no-op effectively and the machine will hang.  Tested the new patch on its way.

https://review.coreboot.org/c/coreboot/+/37562/3/src/security/vboot/ec_sync.... 
PS3, Line 72: BIOS_ERR
> nit: could also be EMERG, like die() uses

Ack