[coreboot-gerrit] [L] Change in coreboot[master]: soc/intel/meteorlake: Add support for crashlog

[Subrata Banik (Code Review)]

Attention is currently required from: Kane Chen, Kapil Porwal, Paul Menzel, Pratikkumar V Prajapati, Tarun Tuli.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74769?usp=email )

Change subject: soc/intel/meteorlake: Add support for crashlog
......................................................................

Patch Set 21:

(4 comments)

File src/soc/intel/meteorlake/crashlog.c:

https://review.coreboot.org/c/coreboot/+/74769/comment/3572f02f_cc2a2d96 :
PS21, Line 61: /* Program BAR 0 and enable command register memory space decoding */
before programming the BAR the best practice says, try to disable the MMIO and IO space and then write the BAR.

https://review.coreboot.org/c/coreboot/+/74769/comment/500397ae_6c8b3138 :
PS21, Line 75: BIOS_DEBUG
should be BIOS_ERROR?

https://review.coreboot.org/c/coreboot/+/74769/comment/a08e104a_53dea3ae :
PS21, Line 80: BIOS_DEBUG
same?

https://review.coreboot.org/c/coreboot/+/74769/comment/2151191f_b83486b1 :
PS21, Line 85: BIOS_DEBUG
same?