Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Jincheng Li, Johnny Lin, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Tim Chu.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80632?usp=email )
Change subject: soc/intel/xeon_sp: Add memory type check utils
......................................................................
Patch Set 5:
(3 comments)
File src/soc/intel/xeon_sp/spr/soc_util.c:
https://review.coreboot.org/c/coreboot/+/80632/comment/fb625c2d_339c7ee6 :
PS4, Line 185: UINT16
`uint16_t` […]
Done
https://review.coreboot.org/c/coreboot/+/80632/comment/397c11d1_a27e238c :
PS4, Line 187: MemTypeCxlAccVolatileMem
Sure, agree that this check needs to be further clarified. Will have a separate patch on this. […]
Per checking SPR FSP headers, this representation should be accurate. However, I added some comments to make this more clear.
File src/soc/intel/xeon_sp/util.c:
https://review.coreboot.org/c/coreboot/+/80632/comment/caf029a8_a1e3ddcd :
PS4, Line 116: bool is_memtype_reserved(UINT16 mem_type)
`uint16_t`
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80632?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f5f3c0f16dc50bc739146e46afce2e5fbf4f62c
Gerrit-Change-Number: 80632
Gerrit-PatchSet: 5
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 27 Feb 2024 01:49:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment