[coreboot-gerrit] Change in coreboot[master]: ec/google/chromeec: Add driver for i2c_tunnel device under Chrome EC

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40515 )

Change subject: ec/google/chromeec: Add driver for i2c_tunnel device under Chrome EC
......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40515/11/src/ec/google/chromeec/Kco... 
File src/ec/google/chromeec/Kconfig:

https://review.coreboot.org/c/coreboot/+/40515/11/src/ec/google/chromeec/Kco... 
PS11, Line 200: if EC_GOOGLE_CHROMEEC
Just a note, I really think this if statement should go inside the sourced files.  This makes it look as if the files won't get sourced unless EC_GOOGLE_CHROMEEC is set, which isn't the case.

In the sourced file, there's nothing to show that it won't get run unless EC_GOOGLE_CHROMEEC is set.