Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35104 )
Change subject: mb/google/drallion: Correct drallion HWID and add HWID for variants
......................................................................
Patch Set 4:
(1 comment)
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35104/3/src/mainboard/google/dralli...
File src/mainboard/google/drallion/Kconfig:
https://review.coreboot.org/c/coreboot/+/35104/3/src/mainboard/google/dralli...
PS3, Line 67: default "ARCADA_CML TEST 4940" if BOARD_GOOGLE_ARCADA_CML
I'm not sure that it's legal to have "_" in the initial part of an hwid entry. […]
I removed the underscore, these two are test boards so it should be fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35104
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I410d37fc3f3372e9420d674b65f2c9a704b670f2
Gerrit-Change-Number: 35104
Gerrit-PatchSet: 4
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Chiranjeevi Rapolu
chiranjeevi.rapolu@intel.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 26 Aug 2019 21:59:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin TerAvest
teravest@chromium.org
Gerrit-MessageType: comment