Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44579 )
Change subject: soc/intel/cnl: Enable HECI3 depending on devicetree ......................................................................
Patch Set 5:
Patch Set 5:
Not all coreboot developers know what HECI 3 is useful for (e.g. me), so having it as a devicetree option seems reasonable.
That's what help texts are there for.
Also, worth adding, it seems that actually *no* coreboot developer knew what `Heci3Enabled` was there for ;)
Shortly before grepping for it in FSP, I realized the typo: why is there a `d`? Usually these options are called `*Enable`. It turned out that this UPD never qualified to be set from a devicetree. One is supposed to set it to a value from a HOB on the resume path. No idea what happens if one sets it to 1 unconditionally. And I doubt anybody ever tried: In the coreboot history it was never set to 1.
You are maintaining ghosts here, folks :)
Meh. Thank you!