4 Apr
2023
4 Apr
'23
5:38 p.m.
Attention is currently required from: Raul Rangel, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74107 )
Change subject: mb/google/myst: Log mainboard events to elog ......................................................................
Patch Set 17:
(1 comment)
File src/mainboard/google/myst/variants/baseboard/smihandler.c:
https://review.coreboot.org/c/coreboot/+/74107/comment/45f16349_0d706ff6 PS5, Line 26: void elog_gsmi_cb_mainboard_log_wake_source(void)
Was this supposed to be removed from this CL? […]
Yea, we should drop and abandon it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74107
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07cd45505f0298065f5fc64ba326c8fc763b847c
Gerrit-Change-Number: 74107
Gerrit-PatchSet: 17
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer markhas@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Tim Van Patten timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Mark Hasemeyer markhas@google.com
Gerrit-Comment-Date: Tue, 04 Apr 2023 17:38:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jon Murphy jpmurphy@google.com
Comment-In-Reply-To: Tim Van Patten timvp@google.com
Gerrit-MessageType: comment