Attention is currently required from: Martin Roth, Christian Walter, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52577 )
Change subject: mb/prodrive/hermes: Implement the mainboard option table interface ......................................................................
Patch Set 2:
(4 comments)
File src/mainboard/prodrive/hermes/option.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117556): https://review.coreboot.org/c/coreboot/+/52577/comment/876263e9_24764d04 PS2, Line 20: #define EEPROM_OPTION(x) if (strcmp(name, #x) == 0) { \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117556): https://review.coreboot.org/c/coreboot/+/52577/comment/86c1b25c_bd3ce8a7 PS2, Line 20: #define EEPROM_OPTION(x) if (strcmp(name, #x) == 0) { \ Macros with flow control statements should be avoided
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117556): https://review.coreboot.org/c/coreboot/+/52577/comment/774df85a_1428d1a6 PS2, Line 55: #define EEPROM_OPTION(x) if (strcmp(name, #x) == 0) { \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117556): https://review.coreboot.org/c/coreboot/+/52577/comment/12b42ff3_a2fc9009 PS2, Line 55: #define EEPROM_OPTION(x) if (strcmp(name, #x) == 0) { \ Macros with flow control statements should be avoided