Attention is currently required from: Martin Roth, Christian Walter, Angel Pons.

View Change

4 comments:

• File src/mainboard/prodrive/hermes/option.c:

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117556):

    Patch Set #2, Line 20: #define EEPROM_OPTION(x) if (strcmp(name, #x) == 0) { \

    Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117556):

    Patch Set #2, Line 20: #define EEPROM_OPTION(x) if (strcmp(name, #x) == 0) { \

    Macros with flow control statements should be avoided

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117556):

    Patch Set #2, Line 55: #define EEPROM_OPTION(x) if (strcmp(name, #x) == 0) { \

    Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects

  • Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117556):

    Patch Set #2, Line 55: #define EEPROM_OPTION(x) if (strcmp(name, #x) == 0) { \

    Macros with flow control statements should be avoided

To view, visit change 52577. To unsubscribe, or for help writing mail filters, visit settings.