Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33236 )
Change subject: cpu/x86: Add STM Support ......................................................................
Patch Set 10:
(2 comments)
Can this be squashed into the other commits?
How can this be tested? With QEMU?
https://review.coreboot.org/#/c/33236/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33236/10//COMMIT_MSG@7 PS10, Line 7: cpu/x86: Add STM Support Please use only one space after the colon.
https://review.coreboot.org/#/c/33236/10/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/#/c/33236/10/src/cpu/x86/mp_init.c@1041 PS10, Line 1041: /* Currently, the CPU SMM save state size is based on a simplistic : * algorithm. (set it to 1K) : * note: In the future, this will need to handle newer x86 processors : * that require 32k alignment of the save state on 32K boundries. */ Please reformat to use the comment style described in the coding style.