Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35266 )
Change subject: drivers/intel/fsp2_0: Use generic defines for early storage ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Marshall, I am trying to get a decision between CB:35165 CB:35233 promptly so we know which one to rebase on the next time around.
I need to run to a meeting, but will look at these when I get back. I considered putting some space into car.ld to positively allocate it, then modify fsp2_0 to use that instead. I wasn't 100% confident that I wouldn't break Intel systems, in the process, though.
Seems we have decided on CB:35233.
BTW, I really disliked this particular PS and I assumed it would be required to change due to whatever changes come before it.
Good, I dislike this too :) I will rebase and update this, there should not be much left to deal with.