Attention is currently required from: Paul Menzel.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79855?usp=email )
Change subject: mb/google/brox: Disable package c state demotion ......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79855/comment/20821514_10a3720a : PS2, Line 7: Disable package c state demotion
… unsupported on RPL
Done. Clarified in the body of the commit.
https://review.coreboot.org/c/coreboot/+/79855/comment/dc2565bb_b8e4d5dc : PS2, Line 11: [EMERG] ASSERTION ERROR: file 'src/soc/intel/alderlake/fsp_params.c', : line 1066
Maybe also describe, what that assertion checks, and why it’s there.
Done
https://review.coreboot.org/c/coreboot/+/79855/comment/e879729c_b7917dc8 : PS2, Line 11: [EMERG] ASSERTION ERROR: file 'src/soc/intel/alderlake/fsp_params.c', : line 1066
I’d put it in one line and indent it with four spaces.
Done