[coreboot-gerrit] Change in coreboot[master]: drivers/intel/gma/edid: Use byte swap function

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38647 )

Change subject: drivers/intel/gma/edid: Use byte swap function
......................................................................

Patch Set 1:

(1 comment)
> Patch Set 1: Code-Review-1
>
> That looks wrong. edid is just 1 byte, so you drop 3 bytes on implicitly casting it.

What do you mean?

https://review.coreboot.org/c/coreboot/+/38647/1/src/drivers/intel/gma/edid.... 
File src/drivers/intel/gma/edid.c:

https://review.coreboot.org/c/coreboot/+/38647/1/src/drivers/intel/gma/edid.... 
PS1, Line 94: reg32
> This variable shouldn't be necessary anymore.

Do you mean `swab32(read32(GMBUS3_ADDR)`?