Attention is currently required from: Raul Rangel, Paul Menzel, Tim Wawrzynczak, Jon Murphy.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63968 )
Change subject: drivers/usb: Add chip driver for external USB hub
......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS2:
What datasheet did you ues?
It is made a generic USB hub now.
File src/drivers/usb/vl/acpi_vl822.c:
https://review.coreboot.org/c/coreboot/+/63968/comment/638e1388_da274429
PS2, Line 91: ViaLabs
Via Labs
It is made a generic external USB now.
https://review.coreboot.org/c/coreboot/+/63968/comment/74a8b1bf_42093856
PS2, Line 91: ViaLabs VL822
I agree. There is nothing specific about this driver for VL822. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63968
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11d7ccc42d3dce8e136eb771f120825980e5c027
Gerrit-Change-Number: 63968
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Comment-Date: Wed, 04 May 2022 21:51:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment
