Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40326 )
Change subject: libpayload/cbfs_core: add arch/types.h include ......................................................................
Patch Set 1:
Patch Set 1:
I think the canonical thing to include here is <stdint.h> (or just <libpayload.h>).
Seems like a lot of libpayload/include headers have arch/types.h. Should this be fixed?
./cbgfx.h:#include <arch/types.h> ./stdint.h:#include <arch/types.h> ./sys/types.h:#include <arch/types.h> ./endian.h:#include <arch/types.h> ./cbfs_core.h:#include <arch/types.h> ./libpayload.h:#include <arch/types.h> ./coreboot_tables.h:#include <arch/types.h> ./stddef.h:#include <arch/types.h> ./pci.h:#include <arch/types.h> ./multiboot_tables.h:#include <arch/types.h>