Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36921 )
Change subject: soc/mediatek/mt8183: skip fast calibration for High frequency of TX RX window ......................................................................
Patch Set 5: Code-Review+1
(2 comments)
seems fine, just few nits in commit message
https://review.coreboot.org/c/coreboot/+/36921/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36921/5//COMMIT_MSG@7 PS5, Line 7: High high
https://review.coreboot.org/c/coreboot/+/36921/5//COMMIT_MSG@9 PS5, Line 9: TX RX window can do fast calibraton at lower frequency, : like 1600Mbps and 2400Mbps. : But high frequency of TX RX window can't do fast calibraton, : like 3200Mbps and 3600Mbps. For low frequency (e.g., 1600 or 2400 Mbps) we can do fast calibration for TX and RX window. However, for high frequency (e.g., 3200 or 3600 Mbps) a full calibration is needed.