HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45610 )
Change subject: northbridge/intel/Kconfig: Introduce DEFAUL BARs_ADDRESS symbols
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45610/3/src/northbridge/intel/Kconf...
File src/northbridge/intel/Kconfig:
https://review.coreboot.org/c/coreboot/+/45610/3/src/northbridge/intel/Kconf...
PS3, Line 1: #SPDX-License-Identifier: GPL-2.0-or-later
nit: space after the `#`
Done
https://review.coreboot.org/c/coreboot/+/45610/3/src/northbridge/intel/Kconf...
PS3, Line 3: DEFAULT_MCHBAR_ADDRESS
`DEFAULT_MCHBAR` should be enough? Or is it giving you problems with the already-defined macros? […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45610
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idca25b2e4bf65abcb3f8b150452ab2567baa60c3
Gerrit-Change-Number: 45610
Gerrit-PatchSet: 10
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 29 Sep 2020 18:03:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment