David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37233 )
Change subject: mb/ocp/monolake: Create SMBIOS type 16 for Monolake platform ......................................................................
Patch Set 2: Code-Review-1
(3 comments)
Hi Morgan, Thanks for doing this, and for cherry-picking to 4.11_branch. The comments below are just carried over from the original patch.
https://review.coreboot.org/c/coreboot/+/37233/2/src/mainboard/ocp/monolake/... File src/mainboard/ocp/monolake/mainboard.c:
https://review.coreboot.org/c/coreboot/+/37233/2/src/mainboard/ocp/monolake/... PS2, Line 34: (32UL << 20) #define MAX_DIMM_SIZE_GB (32 * MiB)
(thanks to Paul for pointing this out - I should have known better when I suggested this form)
https://review.coreboot.org/c/coreboot/+/37233/2/src/mainboard/ocp/monolake/... PS2, Line 81: CONFIG_DIMM_MAX/MAX_IMC; space around / operator
(as per Arthur's comment in CB:36764)
https://review.coreboot.org/c/coreboot/+/37233/2/src/mainboard/ocp/monolake/... PS2, Line 119: #endif if (CONFIG(GENERATE_SMBIOS_TABLES))
(as per Paul's comment in CB:36764, see also CB:31773 for background information)