Shaunak Saha has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix acpi path for gpio. ......................................................................
soc/intel/tigerlake: Fix acpi path for gpio.
In Tigerlake kernel driver list each gpio community as separate gpio devices. Coreboot have the similar changes in ASL file to keep in sync with kernel. Acpigen reads the gpio communities and the drivers populates the SSDT with proper values. Here we fix the acpi path names in coreboot gpio with to be in sync with the separte GPIO communities.
BRANCH=none TEST=From the devicetree for any device when we use driver/usb/acpi verify that in the generates SSDT the path for gpio is populated properly.
Change-Id: Ib03f6b26bafc304e531f2eaeeb0455b8333f1e44 Signed-off-by: Shaunak Saha shaunak.saha@intel.com --- M src/soc/intel/tigerlake/gpio_tgl.c 1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/39344/1
diff --git a/src/soc/intel/tigerlake/gpio_tgl.c b/src/soc/intel/tigerlake/gpio_tgl.c index 54ed5d3..c31f3e3 100644 --- a/src/soc/intel/tigerlake/gpio_tgl.c +++ b/src/soc/intel/tigerlake/gpio_tgl.c @@ -87,7 +87,7 @@ .gpi_smi_en_reg_0 = GPI_SMI_EN_0, .max_pads_per_group = GPIO_MAX_NUM_PER_GROUP, .name = "GPP_BTA", - .acpi_path = "\_SB.PCI0.GPIO", + .acpi_path = "\_SB.PCI0.GCM0", .reset_map = rst_map, .num_reset_vals = ARRAY_SIZE(rst_map), .groups = tgl_community0_groups, @@ -106,7 +106,7 @@ .gpi_smi_en_reg_0 = GPI_SMI_EN_0, .max_pads_per_group = GPIO_MAX_NUM_PER_GROUP, .name = "GPP_SDHU", - .acpi_path = "\_SB.PCI0.GPIO", + .acpi_path = "\_SB.PCI0.GCM1", .reset_map = rst_map, .num_reset_vals = ARRAY_SIZE(rst_map), .groups = tgl_community1_groups, @@ -125,6 +125,7 @@ .gpi_smi_en_reg_0 = GPI_SMI_EN_0, .max_pads_per_group = GPIO_MAX_NUM_PER_GROUP, .name = "GPD", + /* No GCM2 device and group2 is not visible to kernel */ .acpi_path = "\_SB.PCI0.GPIO", .reset_map = rst_map_com2, .num_reset_vals = ARRAY_SIZE(rst_map_com2), @@ -144,7 +145,7 @@ .gpi_smi_en_reg_0 = GPI_SMI_EN_0, .max_pads_per_group = GPIO_MAX_NUM_PER_GROUP, .name = "GPP_FCE", - .acpi_path = "\_SB.PCI0.GPIO", + .acpi_path = "\_SB.PCI0.GCM4", .reset_map = rst_map, .num_reset_vals = ARRAY_SIZE(rst_map), .groups = tgl_community4_groups, @@ -163,7 +164,7 @@ .gpi_smi_en_reg_0 = GPI_SMI_EN_0, .max_pads_per_group = GPIO_MAX_NUM_PER_GROUP, .name = "GPP_CPU_VBPIO", - .acpi_path = "\_SB.PCI0.GPIO", + .acpi_path = "\_SB.PCI0.GCM5", .reset_map = rst_map, .num_reset_vals = ARRAY_SIZE(rst_map), .groups = tgl_community5_groups,