Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45588 )
Change subject: spd: move mainboard_get_dram_part_num to src/vendor/google/chromeos
......................................................................
Patch Set 7:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/45588/7/src/include/spd_bin.h
File src/include/spd_bin.h:
https://review.coreboot.org/c/coreboot/+/45588/7/src/include/spd_bin.h@50
PS7, Line 50: bool mainboard_get_dram_part_num(const char **part_num, size_t *len);
Is len inclusive or exclusive of the NUL terminator? Please add a comment here indicating expectatio […]
Also, what does the return value represent?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45588
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie173b81b9c9a98f3744cc9da4b034d2251f5589b
Gerrit-Change-Number: 45588
Gerrit-PatchSet: 7
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 22 Sep 2020 17:30:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment