[coreboot-gerrit] Change in ...coreboot[master]: nb/intel/sandybridge: Reserve CAR region with !NATIVE_RAMINIT

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31150 )

Change subject: nb/intel/sandybridge: Reserve CAR region with !NATIVE_RAMINIT
......................................................................

Patch Set 4: Code-Review+2

(1 comment)

Looks good enough to me. Is it ready?
> > The blobs repo has multiple binaries for sandy/ivy but we generally end up using systemagent-r6.bin. Do we know the other ones have the same heap? (also do we care?
>
> AFAIR, the other two blobs were built with previous revision of headers, most notably struct pei_data. I don't know why we did not just remove them.

We should. They are just old binaries not compatible with the
current tree anyway.

https://review.coreboot.org/#/c/31150/2/src/northbridge/intel/sandybridge/ra... 
File src/northbridge/intel/sandybridge/raminit_mrc.c:

https://review.coreboot.org/#/c/31150/2/src/northbridge/intel/sandybridge/ra... 
PS2, Line 301: BIOS_DEBUG
> Good question. […]

any update on this?