Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36544 )
Change subject: security/vboot: Add rw_region_only support to vboot
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
If RW and RO need different objects inside them I think it would make sense to generate them separately or even as a separate files, but that's part of a larger redesign. I guess this is good enough as a stop gap measure for now to support your use case.
https://review.coreboot.org/c/coreboot/+/36544/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36544/9//COMMIT_MSG@10
PS9, Line 10: it is required to make sure some components
: are only added to the RW_REGION.
'required to make sure' begs more questions. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36544
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0df9b5dfc6df4f24efc5582a1aec9ecfb48c44d
Gerrit-Change-Number: 36544
Gerrit-PatchSet: 10
Gerrit-Owner: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 08 Nov 2019 13:04:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment