Attention is currently required from: Nico Huber, Paul Menzel, Felix Held.
Clay Daniels has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49112 )
Change subject: superiotool: Add ID for Nuvoton NCT6797D
......................................................................
Patch Set 9:
(2 comments)
Patchset:
PS9:
Nico, the only datasheet I had was for the NCT6791D. I see you seem to have written line 541 to show the NANA entries. What do I need to do next?
File util/superiotool/nuvoton.c:
https://review.coreboot.org/c/coreboot/+/49112/comment/f8a6134f_7bc61e66
PS4, Line 597: {0x00,0xff,0x00,0x00,0x00,0x7f,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0xff,0x00,0x00,0xff,0x00,0x00,0x00,0x00,EOT}},
Hi, do you have the datasheet, though? If so, it would be nice to figure out […]
Nico, the only datasheet I had was for the NCT6791D. I see you seem to have written line 541 to show the NANA entries. What do I need to do next?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49112
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a5f962f2fd9dc479ddbbaf5e1bebea2c7c9e03f
Gerrit-Change-Number: 49112
Gerrit-PatchSet: 9
Gerrit-Owner: Clay Daniels
clay.daniels.jr@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 08 Jan 2021 17:16:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Clay Daniels
clay.daniels.jr@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment