Attention is currently required from: Yu-Ping Wu.
Julius Werner has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/86115?usp=email )
Change subject: symbols: Add REGION() and REGION_END() macros ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Using REGION(name) makes it easier for (new) developers to find the actual region definition.
Hmm... does it? I think it would just make them follow the macro definition to the source but that doesn't really help either. For symbols prefixed with underscores I think there at least exists a lot of precedent among various C code bases to represent linker script symbols that way.
I feel like this adds just another macro that confuses things more without really helping tbh. The duplication of having two different macros with the same name in different headers also adds confusion (especially for people using things like cscope which can find definitions of identifiers but don't take the specific header include chains of the file into account).
If we think these symbols are too confusing I think it would be better to write some more explicit documentation for memlayout stuff and refer to it from prominent places (e.g. a comment in `<symbols.h>`).