Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38350 )
Change subject: soc/intel/broadwell: Don't use _ADR and _HID
......................................................................
Patch Set 8:
(1 comment)
Patch Set 8: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38350/8/src/soc/intel/broadwell/acp...
File src/soc/intel/broadwell/acpi/serialio.asl:
https://review.coreboot.org/c/coreboot/+/38350/8/src/soc/intel/broadwell/acp...
PS8, Line 157: Device (SDMA)
iasl does not complain about having both _HID and _ADR.
Perhaps the compiler only checks if the two exist within the same declarative block?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38350
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e892c451ee9d4e576b568f7efaad2e390524fe0
Gerrit-Change-Number: 38350
Gerrit-PatchSet: 8
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 11 Feb 2020 18:20:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment