[coreboot-gerrit] Change in coreboot[master]: mb/asus/f2a85-m_pro: Enable PCIe bridge 00:15.2 in AGESA

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46527 )

Change subject: mb/asus/f2a85-m_pro: Enable PCIe bridge 00:15.2 in AGESA
......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/c/coreboot/+/46527/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46527/7//COMMIT_MSG@9 
PS7, Line 9: Currently, the PCIe bridge 00:15.2 is not detected by coreboot, causing
           : the connected network device also to be missing.
> this is a rather indirect way of stating what the patch fixes. […]

Stating the problem in the beginning is a good structure in my opinion. Feel free to edit the commit message. I quickly tried, but adding the GPP information was not very consistent either in your proposal.

https://review.coreboot.org/c/coreboot/+/46527/4/src/mainboard/asus/f2a85-m/... 
File src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb:

https://review.coreboot.org/c/coreboot/+/46527/4/src/mainboard/asus/f2a85-m/... 
PS4, Line 114: # FIXME: serial console stops working when enabling resources,
> See patch set 5, it’s not longer than line 111.

Done in PS6.