Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31150 )
Change subject: nb/intel/sandybridge: Reserve CAR region with !NATIVE_RAMINIT
......................................................................
Patch Set 3:
Patch Set 3:
Patch Set 3:
kmalkki: so test on HSW, BDW, BYT then? Assuming IVB is covered by this already
Well I am hoping this would have been improved for haswell already. I don't seem to get or ask the correct questions to get this answered from Google. Mostly because these are 5 years old already.
I can have a look at the output data pointer on haswell to see what it's doing, but a quick look at the binary did not find weird pointers outside the DCACHE_RAM_MRC_VAR region.
The blobs repo has multiple binaries for sandy/ivy but we generally end up using systemagent-r6.bin. Do we know the other ones have the same heap? (also do we care?)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31150
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibc771b592b35d77be81fce87769314fe6bb84c87
Gerrit-Change-Number: 31150
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Feb 2019 13:07:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment