Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45405 )
Change subject: drivers/uart: Override uart base address
......................................................................
Patch Set 2:
I've read through the comments here but missed what the
actual problem statement is. Can somebody wrap it up,
please?
Non-standard i/o addresses were mentioned but how can
that be more user-friendly when one can enter numbers
that don't work? At least early coreboot code used to
configure static addresses, hence only these could be
selected for consoles.
Is this about which physical port is used? Or which
address will be assigned to that port? Does the address
matter after coreboot is done?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45405
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2079bd1e5ffa209553383b6aafe3b8724849ba2a
Gerrit-Change-Number: 45405
Gerrit-PatchSet: 2
Gerrit-Owner: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
philipp.deppenwiese@9elements.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Marc Jones
marc@marcjonesconsulting.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 19 Sep 2020 13:47:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment